Bump the pip group across 4 directories with 3 updates#1151
Bump the pip group across 4 directories with 3 updates#1151dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps the pip group with 1 update in the /examples/llm_ptq directory: [transformers](https://github.com/huggingface/transformers). Bumps the pip group with 1 update in the /examples/windows/onnx_ptq/genai_llm directory: [onnx](https://github.com/onnx/onnx). Bumps the pip group with 1 update in the /examples/windows/onnx_ptq/sam2 directory: [onnx](https://github.com/onnx/onnx). Bumps the pip group with 2 updates in the /examples/windows/onnx_ptq/whisper directory: [torch](https://github.com/pytorch/pytorch) and [onnx](https://github.com/onnx/onnx). Updates `transformers` from 4.48.0 to 4.53.0 - [Release notes](https://github.com/huggingface/transformers/releases) - [Commits](huggingface/transformers@v4.48.0...v4.53.0) Updates `onnx` from 1.19.0 to 1.21.0rc1 - [Release notes](https://github.com/onnx/onnx/releases) - [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md) - [Commits](https://github.com/onnx/onnx/commits) Updates `onnx` from 1.17.0 to 1.21.0rc1 - [Release notes](https://github.com/onnx/onnx/releases) - [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md) - [Commits](https://github.com/onnx/onnx/commits) Updates `torch` from 2.7.0+cu128 to 2.8.0 - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](https://github.com/pytorch/pytorch/commits/v2.8.0) Updates `onnx` from 1.19.0 to 1.21.0rc1 - [Release notes](https://github.com/onnx/onnx/releases) - [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md) - [Commits](https://github.com/onnx/onnx/commits) --- updated-dependencies: - dependency-name: transformers dependency-version: 4.53.0 dependency-type: direct:production dependency-group: pip - dependency-name: onnx dependency-version: 1.21.0rc1 dependency-type: direct:production dependency-group: pip - dependency-name: onnx dependency-version: 1.21.0rc1 dependency-type: direct:production dependency-group: pip - dependency-name: torch dependency-version: 2.8.0 dependency-type: direct:production dependency-group: pip - dependency-name: onnx dependency-version: 1.21.0rc1 dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com>
cjluo-nv
left a comment
There was a problem hiding this comment.
Summary: Dependabot PR bumping transformers, onnx, and torch across example requirements and project config files. The PR description is stale (mentions 4.48.0→4.53.0) but the actual diff shows much larger version jumps including transformers to 5.4.0 and onnx to 1.21.0rc1.
Issues Found:
-
[Correctness] Version guard in
modelopt/torch/__init__.py:35not updated. Thepyproject.tomlnow allowstransformers>=4.56,<6.0, but the runtime version check still enforces< _Version("5.0"). This means anyone installing transformers 5.x (which this PR enables) will get a warning on every import. The comment on the pyproject.toml line says "Should match modelopt/torch/init.py and tox.ini" — neither was updated. -
[Correctness]
tox.ini:27not updated. The comment says it should matchpyproject.toml, buttox.inistill pinstransformers~=4.56.0as the minimum test version. If the intent is to support transformers 5.x, there should be atf_maxor similar test environment to validate against 5.x. -
[Correctness]
onnx==1.21.0rc1is a release candidate. Three example requirements files pin to an RC version. RC versions can have breaking changes before final release and shouldn't be pinned in shipped examples. Use1.20.1(latest stable) or wait for 1.21.0 final. -
[Correctness]
torchaudioversion mismatch inexamples/windows/onnx_ptq/whisper/requirements.txt.torchis bumped from2.7.0+cu128to2.8.0, buttorchaudioremains at2.7.0+cu128on the next line. PyTorch and torchaudio versions must be compatible — mixing 2.8.0 torch with 2.7.0 torchaudio will likely fail at import time. -
[Correctness]
torchandtransformersversions inconsistent acrossgenai_llm/requirements.txt. This file pinstorch==2.11.0andtransformers==5.4.0— these are versions that don't exist yet as of the knowledge cutoff. The PR description mentionstorch2.8.0 but the diff shows 2.11.0 for genai_llm. This looks like the Dependabot resolved to different targets across directories. -
[Correctness]
requirements-vila.txtupper bound jump. The VILA requirements go fromtransformers<=4.50.0totransformers<=5.4.0— a very large upper bound increase. VILA integration should be explicitly tested against transformers 5.x before opening up this range.
Suggestions:
- Update
modelopt/torch/__init__.py:35to< _Version("6.0")to match pyproject.toml. - Update
tox.inito add a transformers 5.x test environment. - Pin onnx to
1.20.1(stable) instead of1.21.0rc1. - Fix the torchaudio version in whisper requirements to match the torch version.
- Verify that
torch==2.11.0in genai_llm is intentional (it appears unreleased).
Overall Assessment: This PR has multiple version inconsistencies and missing updates to runtime version checks. The most critical issue is that the version guard in __init__.py actively contradicts the new pyproject.toml range, and pinning to an RC version of onnx is inappropriate for example code. Needs revision.
|
Needs proper testing and maybe more updates since we dont have cicd testing for windows examples. Closing this |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
|
Bumps the pip group with 1 update in the /examples/llm_ptq directory: transformers.
Bumps the pip group with 1 update in the /examples/windows/onnx_ptq/genai_llm directory: onnx.
Bumps the pip group with 1 update in the /examples/windows/onnx_ptq/sam2 directory: onnx.
Bumps the pip group with 2 updates in the /examples/windows/onnx_ptq/whisper directory: torch and onnx.
Updates
transformersfrom 4.48.0 to 4.53.0Release notes
Sourced from transformers's releases.
... (truncated)
Commits
67ddc82Release: v4.53.00a8081b[Modeling] Fix encoder CPU offloading for whisper (#38994)c63cfd6Gemma 3n (#39059)3e5cc12[tests] remove tests from libraries with deprecated support (flax, tensorflow...cfff7ca[Whisper] Pipeline: handle long form generation (#35750)02ecdcfadd _keep_in_fp32_modules_strict (#39058)d973e62fix condition where torch_dtype auto collides with model_kwargs. (#39054)44b2316[qwen2-vl] fix vision attention scaling (#39043)ae15715polishing docs: error fixes for clarity (#39042)3abeabaCreate test for #38916 (custom generate from local dir with imports) (#39015)Updates
onnxfrom 1.19.0 to 1.21.0rc1Release notes
Sourced from onnx's releases.
... (truncated)
Commits
Updates
onnxfrom 1.17.0 to 1.21.0rc1Release notes
Sourced from onnx's releases.
... (truncated)
Commits
Updates
torchfrom 2.7.0+cu128 to 2.8.0Release notes
Sourced from torch's releases.
... (truncated)
Commits
Updates
onnxfrom 1.19.0 to 1.21.0rc1Release notes
Sourced from onnx's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.